Huh! ConfigurationDumper still uses \Sensio\Bundle\DistributionBundle\Configurator\Configurator which was removed in 5.0...

It looks like it writes a random secret to app/config/parameters.yml after legacy setup wizard is ran.

I think it's safe to remove it: https://github.com/ezsystems/LegacyBridge/blob/master/bundle/SetupWizard/ConfigurationDumper.php#L101-L108

@bdunogier WDYT?

@wizhippo Your input is appreciated too :)

@emodric I believe that should be able to be removed too with no issue as when you use composer to install you are asked to set the secret. I see no need to reset the secret again from the legacy setup wizard.

I agree with you guys.

PR updated to remove the configurator.

Ping @lolautruche

From my side +1 but wanted JV's pov

Shouldn't we regenerate the secret?

Other than that, +1

Why though?

Initial composer install asks the user to set the secret. Why should legacy bridge install regenerate user set secret?

Initial composer install asks the user to set the secret. Why should legacy bridge install regenerate user set secret?

I think I agree with that.

Alright then :-)

v1.1.0 or even v2.0 version for this maybe then? Other feature changes we should aim for while at it?

I'd say 1.1.0 because it can be a blocker sometimes.

1.1.0 sounds okay. I'd like to push another PR to fix deprecations in YML, after merging this, but before tagging.

Can this be backported to 5.4 please?

DistributionBudle 3.x is way too old and is causing issues with composer such as:

  PHP Warning:  Module 'sysvshm' already loaded in Unknown on line 0
  PHP Warning:  Module 'tokenizer' already loaded in Unknown on line 0
  PHP Warning:  Module 'wddx' already loaded in Unknown on line 0
  PHP Warning:  Module 'xmlreader' already loaded in Unknown on line 0
  PHP Warning:  Module 'xmlwriter' already loaded in Unknown on line 0
  PHP Warning:  Module 'xsl' already loaded in Unknown on line 0
  PHP Warning:  Module 'zip' already loaded in Unknown on line 0

Thanks :-)

@lolautruche Latest Distribution bundle 4.x works fine :)

OK I'll check this out, thanks @emodric